build: add sensible default for WORKSPACE - #1349
Merged
joaodinissf merged 2 commits intoMay 19, 2026
Merged
Conversation
Register tycho-build as a Maven core extension so `mvn -pl :<module> -am` walks Require-Bundle / Import-Package when computing the reactor — without it, only Maven <dependency> blocks are considered. Version pinned via .mvn/maven.config to track ddk-parent's tycho.version. Incompatible with mvnd; use plain mvn for -am. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
joaodinissf
force-pushed
the
build/default-workspace-property
branch
from
May 18, 2026 16:53
121328b to
f757aec
Compare
joaodinissf
marked this pull request as ready for review
May 18, 2026 16:54
joaodinissf
enabled auto-merge (rebase)
May 18, 2026 16:54
`<workspace>` defaults to ${maven.multiModuleProjectDirectory} when the
WORKSPACE env var is unset. CI's env-var path is unchanged.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
joaodinissf
force-pushed
the
build/default-workspace-property
branch
from
May 18, 2026 16:56
f757aec to
da6f075
Compare
rubenporras
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
<workspace>inddk-parentnow defaults to${maven.multiModuleProjectDirectory}(= repo root) when theWORKSPACEenv var is unset. CI keeps settingWORKSPACEexplicitly; that path is unchanged.Drops the
export WORKSPACE=…instruction from AGENTS.md — local devs no longer need it.