chore: enable PMD GuardLogStatement rule - #1284
Merged
Merged
Conversation
joaodinissf
marked this pull request as draft
March 7, 2026 15:16
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
4 times, most recently
from
April 6, 2026 20:24
552a8ad to
f9540a3
Compare
joaodinissf
changed the title
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
from
April 6, 2026 20:42
f9540a3 to
8ce505d
Compare
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
2 times, most recently
from
April 20, 2026 08:21
3cf146e to
eb41fd2
Compare
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
from
May 6, 2026 23:55
eb41fd2 to
df80f66
Compare
joaodinissf
marked this pull request as ready for review
May 6, 2026 23:55
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
from
May 6, 2026 23:56
df80f66 to
afcd414
Compare
rubenporras
requested changes
May 19, 2026
rubenporras
left a comment
rubenporras
left a comment
Member
There was a problem hiding this comment.
you need rebase and resolve conflicts
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
2 times, most recently
from
May 19, 2026 08:45
827b3e1 to
cd33a62
Compare
joaodinissf
enabled auto-merge (rebase)
May 19, 2026 08:45
Remove the GuardLogStatement exclusion and configure the rule for debug/trace levels. Also replace bare TODO comments on remaining excluded rules (PreserveStackTrace, UseTryWithResources) with actionable descriptions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joaodinissf
force-pushed
the
chore/pmd-todo-cleanup
branch
from
May 19, 2026 12:19
cd33a62 to
3526d12
Compare
rubenporras
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
category/java/bestpractices.xml/GuardLogStatementPMD rule fortraceanddebuglevels withisTraceEnabled/isDebugEnabledas the recognised guard methods. The cluster of refactors that converted eager log-statement string concatenation to parameterized{}placeholders /Supplierlambdas (test utilities, DDK core, DDK builder/generator/UI) is what makes this rule pass without violations.🤖 Generated with Claude Code