feat: QualifiedNameLookup extensions - #1221
Conversation
ava-fred
commented
Nov 13, 2025
- allow one object to be initialized from another
- make QualifiedNameSegmentTreeLookup externalizable
21a473f to
7e70e82
Compare
| com.avaloq.tools.ddk.xtext.ui.test, | ||
| com.avaloq.tools.ddk.sample.helloworld.test | ||
| com.avaloq.tools.ddk.sample.helloworld.test, | ||
| com.avaloq.tools.ddk.caching |
There was a problem hiding this comment.
why do we need com.avaloq.tools.ddk.caching, could we take the MANIFEST.MF modifications out of the PR? I do not see any usage in the modifications in the PR.
There was a problem hiding this comment.
There used to be a usage in QualifiedNameSegmentTreeLookupTest: I logged the number of entries after readback, which needed the CacheStatistics type. The logging was removed so we don't need the package any more, I will update the PR.
| /******************************************************************************* | ||
| * Copyright (c) 2016 Avaloq Group AG and others. | ||
| * All rights reserved. This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Public License v1.0 |
There was a problem hiding this comment.
this file has a lot of whitespace changes, can we avoid those?
There was a problem hiding this comment.
No idea how. As far as I can see, the line endings are still CRLF like they were before and indentation is space, not tab. Any hints?
There was a problem hiding this comment.
let us not loose time on it then
- allow one object to be initialized from another - make QualifiedNameSegmentTreeLookup externalizable
7e70e82 to
db015ac
Compare