Skip to content

feat: QualifiedNameLookup extensions - #1221

Merged
ava-fred merged 1 commit into
dsldevkit:masterfrom
ava-fred:work.251107
Nov 13, 2025
Merged

feat: QualifiedNameLookup extensions#1221
ava-fred merged 1 commit into
dsldevkit:masterfrom
ava-fred:work.251107

Conversation

@ava-fred

Copy link
Copy Markdown
Collaborator
  • allow one object to be initialized from another
  • make QualifiedNameSegmentTreeLookup externalizable

@ava-fred
ava-fred requested a review from rubenporras November 13, 2025 05:10
@ava-fred
ava-fred force-pushed the work.251107 branch 4 times, most recently from 21a473f to 7e70e82 Compare November 13, 2025 06:15

@rubenporras rubenporras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

com.avaloq.tools.ddk.xtext.ui.test,
com.avaloq.tools.ddk.sample.helloworld.test
com.avaloq.tools.ddk.sample.helloworld.test,
com.avaloq.tools.ddk.caching

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need com.avaloq.tools.ddk.caching, could we take the MANIFEST.MF modifications out of the PR? I do not see any usage in the modifications in the PR.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There used to be a usage in QualifiedNameSegmentTreeLookupTest: I logged the number of entries after readback, which needed the CacheStatistics type. The logging was removed so we don't need the package any more, I will update the PR.

/*******************************************************************************
* Copyright (c) 2016 Avaloq Group AG and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file has a lot of whitespace changes, can we avoid those?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how. As far as I can see, the line endings are still CRLF like they were before and indentation is space, not tab. Any hints?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us not loose time on it then

- allow one object to be initialized from another
- make QualifiedNameSegmentTreeLookup externalizable
@ava-fred
ava-fred merged commit 5ffbe40 into dsldevkit:master Nov 13, 2025
2 checks passed
@ava-fred
ava-fred deleted the work.251107 branch November 13, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants