Repository navigation
feat: --uid-shell-bar-height — the sidebar's header and the top bar share one line - #184
Merged
Merged
Conversation
…hare one line The top bar was 56px with its line; the sidebar's header was as tall as its content plus 16px above and below, so the lines under the two missed each other by a pixel or several, differently in every app. Both now take --uid-shell-bar-height (56px): the top bar as its height, the header as its least height with the content centred, and the same subtle line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar's header and the top bar now share one bottom line: the new
--uid-shell-bar-height(56px) is the top bar's height and the header's minimum height, the header's content is centred, and both use the--uid-border-subtleline. Before, the header's height depended on its content plus 16px padding, so the line was off by a different amount in each app.Tests:
vitest1627 passed. Build is OK.🤖 Generated with Claude Code