fix: retain release package identity in installed views - #98
Merged
dshplugin merged 1 commit intoOct 5, 2026
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hub v1.4.14 successfully installs the catalog's prebuilt GitHub release package, but the Client still leaves its installed dependency unmatched:
repoFromInstallTargetdoes not recognize the fixed release URL stored by DSH. The catalog card continues to appear uninstalled and the Installed view loses its catalog identity/update signal.Reuse the existing strict
githubReleaseTargetparser in that Client identity helper, matching the server-side implementation shipped for #93. No new URL grammar or installation authority is introduced. This restores catalog matching after installation or reload, keeps an older pinned artifact associated with the catalog's newer version, and clears the row after package-name removal. Cross-repository and invalid targets remain unmatched. The tracked Client bundle is rebuilt for Git installation.Validation: type checks, server/Client builds and all 107 runnable tests passed (109 total; two platform-specific skips). The new regression exercises installed matching, one catalog-associated row, update detection, removal and foreign/invalid targets. A disposable real native DSH profile using the actual npm-released v1.4.14 backend reproduced the original installed-state failure; with this Client helper it passed live-catalog release installation, identity readback, pinned update and package-name removal. Mounted browser interaction is not claimed.