Skip to content

OpticalDiskDriveLetter: Fix finding drive on Azure Windows Server 2022 - #275

Open
tj-spyro wants to merge 2 commits into
dsccommunity:mainfrom
tj-spyro:issue274-opticaldiskdriveletter-windows2022
Open

OpticalDiskDriveLetter: Fix finding drive on Azure Windows Server 2022#275
tj-spyro wants to merge 2 commits into
dsccommunity:mainfrom
tj-spyro:issue274-opticaldiskdriveletter-windows2022

Conversation

@tj-spyro

@tj-spyro tj-spyro commented May 23, 2023

Copy link
Copy Markdown

Pull Request (PR) description

Added support for changing optical disk drive letter on Windows Server 2022 where the DeviceId appears to be longer than 10 characters in length.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov

codecov Bot commented May 23, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95%. Comparing base (4a9e4fa) to head (3db5666).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #275   +/-   ##
===================================
  Coverage    95%    95%           
===================================
  Files         7      7           
  Lines       882    889    +7     
===================================
+ Hits        842    849    +7     
  Misses       40     40           
Files with missing lines Coverage Δ
...calDiskDriveLetter/DSC_OpticalDiskDriveLetter.psm1 93% <100%> (+<1%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju
johlju requested a review from PlagueHO September 23, 2023 07:28
@johlju johlju added the needs review The pull request needs a code review. label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpticalDiskDriveLetter: The optical disk 1 could not be found in the system on Azure Windows Server 2022

2 participants