ci: match tests/** in the ansible filter so test-only PRs run their tests#120
Merged
Merged
Conversation
…ests Callers gate pytest and ansible-lint on the `ansible` filter. Its globs covered YAML suites via '**.yml' but nothing matched a Python suite under tests/, so a test-only change produced SKIPPED on both jobs, Merge Gate allowed the skips, and the PR could merge on a green board without its tests ever running. This is the same gap fixed for the molecule filter, which was corrected separately because the two gate different jobs — which is precisely why this second instance survived the first fix. Assisted-by: Claude:claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_01Kqn6PLZhCzVdfLt7E7EFMg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers gate
data-contract(pytest) andAnsible Lintonneeds.ci.outputs.ansible. Theansiblefilter did not matchtests/**— its globs cover a YAML suite via**.yml, but a Python suite undertests/matched nothing. Both jobs reported SKIPPED, Merge Gate allowed the skips, and a test-only PR could merge on a green board having never run a test.Found on a live PR: a test-only change under
tests/hermes_agent/showed SKIPPED for both jobs, so its verification was local-only and not CI-enforced.The
moleculefilter had the same blind spot and was fixed separately, because the two filters gate different jobs — fixing one did not fix the other, which is exactly why this instance survived. Both now carrytests/**.One glob added, plus a comment recording why. No job logic changed.