Fix export_data.py broken method calls and add CLAUDE.md - #1
Open
drtamar wants to merge 2 commits into
Open
Conversation
- Replace non-existent get_user_top_artists()/get_user_top_tracks() calls with the correct get_top_items(item_type=...) method in export_data.py - Fix type hint: `any` -> `Any` (add Any to typing imports) - Add CLAUDE.md with commands, architecture overview, and credential flow guidance for future Claude Code sessions https://claude.ai/code/session_01KDZHKzQGxs3YFL39cvkReU
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a CLAUDE.md file to provide architectural guidance and command references for Claude Code. Additionally, it refactors spotify-api/scripts/export_data.py to use the consolidated get_top_items method for fetching artists and tracks, and improves type hinting by using Any from the typing module. I have no feedback to provide.
- Fix get_user_top_artists/tracks -> get_top_items(item_type=...) in export_data.py - Add Any to typing imports and fix data: any -> data: Any type hint - Add CLAUDE.md with commands, architecture, and credentials flow - Add session_summary.json for next session context handoff https://claude.ai/code/session_01KDZHKzQGxs3YFL39cvkReU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with the correct get_top_items(item_type=...) method in export_data.py
any->Any(add Any to typing imports)guidance for future Claude Code sessions
https://claude.ai/code/session_01KDZHKzQGxs3YFL39cvkReU