Repository navigation
ci: gate pull requests on conventional commits (cocogitto) - #18
Merged
Merged
Conversation
Conventional commits are written by hand across this fleet and drift silently. `cog check` now runs on pull requests over the range the PR adds, against the types this repo actually uses — `licence` and `sweep` are declared alongside the standard set, because 52 of the 82 commits written before this gate used a type outside it and a gate that relitigated them would be red on arrival. Advisory (`continue-on-error`) until a few PRs pass through it clean, matching how rustfmt and clippy are already gated here.
Owner
Author
|
Negative test, run locally with the same pinned binary and this repo's In the same range, And on the PR itself, the job in 6s: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the fourth of CLDR's reference links —
cocogitto— as a CI-only gate.What it does.
cog checkruns onpull_requestover the commits the PR adds (base.sha..head.sha), against acog.tomlthat declares the types this repo actually uses.licence:(12 commits) andsweep:are in the list alongside the standard set; without them the gate would have been red on history it was never meant to judge.Advisory, not blocking.
continue-on-error: true, matching howrustfmtandclippyare already gated here. Promote it once a few PRs have gone through clean.Scope, stated plainly: it judges new commits only. The 82 commits already on
mainare not relitigated — 52 of them use a type outside the standard set, and rewriting history to satisfy a linter is not a change I would make to a shipped repo.Dependency: cocogitto 7.0.0, pinned, downloaded from its GitHub release (musl x86_64, ~2 MB) and installed into the runner. It never touches the shipped binary: no crate, no runtime dependency, nothing added to
Cargo.toml.Evidence is the
Conventional commitsjob on this PR itself — the first PR it has ever run on. Nothing else in the workflow changed.