modified logging to use python lists rather than preallocated arrays - #60
Open
kamdh wants to merge 1 commit into
Open
modified logging to use python lists rather than preallocated arrays#60kamdh wants to merge 1 commit into
kamdh wants to merge 1 commit into
Conversation
… as this is more pythonic and there was a bug with previous preallocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more pythonic and there was a bug with previous preallocation. The info is still returned as a numpy array. I've attached a minimal example that reproduces the error with the saved data.
Error:
min_err_example.zip