Conversation
A dedicated RPC streams ChainDescription events per node group, tagged with node_group_id; SubscribeChainStatus keeps the merged view and is untouched. Generated with the pinned toolchain (protoc 36.1, protoc-gen-go v1.36.12, protoc-gen-go-grpc v1.6.1), so the rest of pkg/dshackle is unchanged.
l0gun0v
pushed a commit
to drpcorg/nodecore
that referenced
this pull request
Sep 21, 2026
main moved the generated protos out of the repo (submodules removed, now github.com/drpcorg/public/pkg/dshackle), so the pb.go edits this branch carried are dropped and the new RPC comes from public instead - pinned to the branch of drpcorg/public#275 until that merges. Conflict resolution in internal/upstreams: - BaseChainSupervisor -> GenericChainSupervisor rename applied to the group code this branch adds. - main's stricter processSubMethods (a sub method must be supported by some upstream, and either be a grpc server stream or have WsCap) replaces the older copy this branch had moved into chain_supervisor_state.go, so group states get the same rule as the merged view.
l0gun0v
marked this pull request as ready for review
September 24, 2026 08:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the SEPARATION stack (DRPCPROT-603). The protos moved here from
emerald-grpcin #2873's counterpart, so the RPC the stack needs now has to be added in this repo.What
proto/blockchain.proto: newrpc SubscribeNodeGroupStatus (SubscribeNodeGroupStatusRequest) returns (stream SubscribeChainStatusResponse)plusnode_group_idonChainDescription.pkg/dshackle: regenerated.SubscribeChainStatusis untouched — the merged per-network view keeps its current shape, andnode_group_idis always empty there.Generation
Regenerated with the toolchain the committed files were produced with — protoc 36.1, protoc-gen-go v1.36.12, protoc-gen-go-grpc v1.6.1 — verified by regenerating without the proto change first and getting a zero diff. So everything outside the new RPC/field is rawDesc reflow, not a toolchain bump.
Stack
Both bump
github.com/drpcorg/publicto this branch until it merges.