Add max_age_days filter to search_issues - #159
Open
SHEKHAR-Y wants to merge 1 commit into
Open
Conversation
drkrillo
reviewed
Aug 31, 2026
drkrillo
left a comment
drkrillo
left a comment
Owner
There was a problem hiding this comment.
Hi @SHEKHAR-Y !
PR is looking good.
Left a minor comment in the code: Inapp/tests/test_mcp_server.py, DatasetManager is imported but never used. Push that one and we are ready to merge. Thanks for the back and forth on the issue, the updated_at call was yours and it was the right one.
| import pytest | ||
|
|
||
| from mcp.server.mcpserver import MCPServer | ||
| from app.core.dataset import DatasetManager |
Owner
There was a problem hiding this comment.
We should leave this import out since it's not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Filtering the issues on the basis of updated_at so that only issues which are active will be searched, also the max_age_days is inclusive of the boundary to ensure if it is set 0 it will return the issues opened or updated today.
Issues with empty updated_at are excluded when max_age_days is set, since we can't verify the recency of the issue and the whole point of this feature is filtering out the stale issues.
Added 4 new tests covering basic age filtering, inclusive boundary case, empty updated_at exclusion and when max_age_days not passed.
Full suite passes, 100% coverage maintained.
Related Issue
Fixes #155
Checklist