-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync v0.15.3 release commits from main into develop #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomymaritano
wants to merge
6
commits into
develop
Choose a base branch
from
main
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cd269c8
fix(release): cut v0.15.1 after Phase 0 DevOps stabilization (#297)
tomymaritano 2b5ea9e
chore(release): v0.15.1 [skip ci]
github-actions[bot] 33769fc
fix(release): cut v0.15.2 with linux executableName fix (#301)
tomymaritano e471ad8
chore(release): v0.15.2 [skip ci]
github-actions[bot] c755a67
fix(release): cut v0.15.3 with window/db lifecycle crash fixes (#304)
tomymaritano 1cb1640
chore(release): v0.15.3 [skip ci]
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this setup cache is populated from
pnpm install --ignore-scripts, dependency install scripts such as Electron's binary download are skipped. The latere2ejob restores this samenode_modulescache and launches the app via Playwright's Electron fixture (apps/desktop/e2e/fixtures.tsuses_electron.launch), but it never reruns installs without--ignore-scripts, so a clean CI run will have theelectronpackage without itsdistexecutable and the E2E job will fail before exercising the app. Keep scripts enabled for the E2E dependency path or add a targeted Electron install in that job.Useful? React with 👍 / 👎.