Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions release.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ export default {
},
],
'@semantic-release/changelog',
[
'@semantic-release/exec',
{
prepareCmd: 'node scripts/bump-version.js ${nextRelease.version}',
},
],
// Note: the previous @semantic-release/exec step ran a custom
// scripts/bump-version.js to sync per-package versions. That script was
// deleted in the knip cleanup (#279) and the desktop release only needs
// the root + apps/desktop package.json versions bumped — which the
// @semantic-release/git plugin below does via the `assets` list. So we
// drop the exec step entirely.
Comment on lines +39 to +40

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore a version-bumping prepare step

In the manual Release workflow on main, this config now has no prepare plugin that writes the computed nextRelease.version into either package.json; @semantic-release/git only commits files that were already modified, and the official git plugin docs say @semantic-release/npm must run first to update package.json so git can include it. For the intended v0.15.0 release, semantic-release can therefore tag/publish a v0.15.0 release while the Build workflow checks out a tree where apps/desktop/package.json is still 0.14.0, so electron-builder produces an app/artifacts with the old version.

Useful? React with 👍 / 👎.

[
'@semantic-release/git',
{
Expand Down
Loading