Skip to content

chore: scope Codex tools to personal services - #96

Closed
dreamiurg wants to merge 1 commit into
mainfrom
codex/project-tool-isolation
Closed

dreamiurg wants to merge 1 commit into
mainfrom
codex/project-tool-isolation

Conversation

@dreamiurg

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated application configuration to disable the default integration.
    • Added support for connecting to a personal Notion MCP server.

Walkthrough

Codex configuration disables the default app integration and adds a personal Notion MCP server endpoint.

Changes

Codex MCP configuration

Layer / File(s) Summary
Configure app and MCP integrations
.codex/config.toml
Disables the default app and configures notion_personal with the Notion MCP endpoint.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required Summary, Type, and Changes sections are missing. Add the template sections Summary, Type, and Changes, and briefly describe the Codex config change and its purpose.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: restricting Codex tools to personal services.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (4d1d0ed) to head (9fadbe4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          11       11           
  Lines        2026     2026           
  Branches      265      265           
=======================================
  Hits         1894     1894           
  Misses         84       84           
  Partials       48       48           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.codex/config.toml:
- Around line 4-5: Remove the mcp_servers.notion_personal configuration from the
committed .codex/config.toml, and place it in a user-local Codex configuration
or ignored local override so the Notion MCP server is not enabled for every
checkout.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 891e20d5-ab33-45b1-8e6e-f325434f4abb

📥 Commits

Reviewing files that changed from the base of the PR and between c301843 and 9fadbe4.

📒 Files selected for processing (1)
  • .codex/config.toml

Comment thread .codex/config.toml
Comment on lines +4 to +5
[mcp_servers.notion_personal]
url = "https://mcp.notion.com/mcp"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Repo root: '
pwd

echo
echo 'Tracked files under .codex:'
git ls-files .codex .codex/config.toml .codex/** 2>/dev/null || true

echo
echo 'File info:'
stat -c '%n %s bytes' .codex/config.toml 2>/dev/null || true

echo
echo 'Contents of .codex/config.toml:'
cat -n .codex/config.toml 2>/dev/null || true

echo
echo 'Search for notion_personal and MCP config references:'
rg -n --hidden --no-ignore-vcs 'notion_personal|mcp_servers|mcp\.notion\.com|codex/config\.toml' . || true

Repository: dreamiurg/peakbagger-cli

Length of output: 584


🏁 Script executed:

#!/bin/bash
set -euo pipefail
pwd
git ls-files .codex .codex/config.toml .codex/** 2>/dev/null || true
stat -c '%n %s bytes' .codex/config.toml 2>/dev/null || true
cat -n .codex/config.toml 2>/dev/null || true
rg -n --hidden --no-ignore-vcs 'notion_personal|mcp_servers|mcp\.notion\.com|codex/config\.toml' . || true

Repository: dreamiurg/peakbagger-cli

Length of output: 444


Move mcp_servers.notion_personal out of .codex/config.toml. This committed, repo-scoped config enables the Notion MCP server for every checkout, exposing contributors’ authenticated Notion workspace to repo instructions or prompt injection. Use a user-local Codex config or an ignored override instead.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.codex/config.toml around lines 4 - 5, Remove the
mcp_servers.notion_personal configuration from the committed .codex/config.toml,
and place it in a user-local Codex configuration or ignored local override so
the Notion MCP server is not enabled for every checkout.

@dreamiurg dreamiurg closed this Jul 15, 2026
@dreamiurg
dreamiurg deleted the codex/project-tool-isolation branch July 15, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant