Repository navigation
ci: run the debug and release checks in a single job - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran two jobs on every push:
test_debug(cargo build,cargo test) andtest_release(the wasm build,cargo test --releaseand the npm test). They are now one job that runscargo testin debug, sodebug_assert!and overflow checks still run, then the wasm release build and the npm test against it. Tags release from the same job.cargo test --releaseis dropped. The release profile turns off debug assertions and overflow checks, so it ran the same tests with fewer checks while costing a native release build, and the shipped wasm is still exercised by the npm test. This halves the runners used per push.