Repository navigation
chore: remove the wasm_plugin re-export - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
pub use wasm_plugin::*;fromsrc/lib.rs.Since dprint-core 0.71.1,
generate_plugin_code!puts the functions it generates insideconst _: () = { ... }, so the re-export has nothing to re-export, andcargo check --target wasm32-unknown-unknown --features wasmwarns that it's unused onceCargo.lockmoves to 0.71.1. It isn't needed with older dprint-core versions either: the exports are#[no_mangle], which rustc exports from the cdylib even when they're in a private module.cargo check --target wasm32-unknown-unknown --features wasmpasses with no warnings. I also built the release wasm of dprint-plugin-cedar (dprint-core 0.71.0) and dprint-plugin-typescript (0.62.1, the oldest in the org) with and without the re-export, and their exports were identical.