Skip to content

fix: use gh release create so releases work with immutable releases #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsherret merged 1 commit into from
Oct 17, 2026
Merged

fix: use gh release create so releases work with immutable releases #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/ci.generated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,14 @@ jobs:
# create release notes
deno run -A ./scripts/generateReleaseNotes.ts ${{ steps.get_tag_version.outputs.TAG_VERSION }} > ${{ github.workspace }}-CHANGELOG.txt
- name: Release
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844
if: 'matrix.config.kind == ''test_release'' && startsWith(github.ref, ''refs/tags/'')'
env:
GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
with:
files: |-
target/wasm32-unknown-unknown/release/plugin.wasm
GH_TOKEN: '${{ secrets.GITHUB_TOKEN }}'
run: |-
gh release create "$GITHUB_REF_NAME" --verify-tag --title "$GITHUB_REF_NAME" \
--notes-file ${{ github.workspace }}-CHANGELOG.txt \
target/wasm32-unknown-unknown/release/plugin.wasm \
deployment/schema.json
body_path: '${{ github.workspace }}-CHANGELOG.txt'
draft: false
- name: Lint workflow generation
if: matrix.config.kind == 'test_debug'
run: |-
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/ci.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,15 @@ const buildJob = job("build", {
},
{
name: "Release",
// pinned because softprops/action-gh-release was once compromised
uses: "softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844",
if: isReleaseAndTag,
env: { GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" },
with: {
files: [
"target/wasm32-unknown-unknown/release/plugin.wasm",
"deployment/schema.json",
].join("\n"),
body_path: "${{ github.workspace }}-CHANGELOG.txt",
draft: false,
},
// gh uploads the assets to a draft and then publishes it, which immutable releases require
env: { GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}" },
run: [
`gh release create "$GITHUB_REF_NAME" --verify-tag --title "$GITHUB_REF_NAME"`,
"--notes-file ${{ github.workspace }}-CHANGELOG.txt",
"target/wasm32-unknown-unknown/release/plugin.wasm",
"deployment/schema.json",
].join(" \\\n "),
},
{
name: "Lint workflow generation",
Expand Down
Loading