chore(fusillade): remove dead DaemonExecutor impl for PostgresDaemon - #1710
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
af42682
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ded928fd.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-fusil-nvx7.control-layer.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
impl DaemonExecutor<H> for PostgresDaemontraitimpl, plus the
http_client()andconfig()inherent getters whoseonly caller was that impl's forwarders.
The
DaemonExecutortrait has no trait-dispatch consumers anywhere inthe workspace (no
dyn, generic bound, or qualified call-site). dwctlwas migrated to
PostgresDaemon's inherent methods in the split-daemonruntime upgrade (6c0607c), which deliberately removed dwctl's
use fusillade::DaemonExecutor;imports and trait-dispatch call-sites,leaving this impl vestigial.
fusilladeispublish = falseand thepackage_boundariestest does not assert onDaemonExecutor, soremoval carries no external-consumer risk.
Dead Code PRs can be configured here.