chore(fusillade): remove orphaned daemon types module - #1709
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
59df7cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://763db673.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-fusil.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the orphaned
fusillade/src/daemon/types.rsfile (200 LOC), which declared the typestate daemon record types (DaemonState,DaemonRecord,DaemonData,Initializing,Running,Dead,DaemonStats,AnyDaemonRecord,DaemonStatus, andget_hostname/get_pid/get_versionhelpers).The file was dead:
fusillade/src/daemon/mod.rsnever declaresmod types;, so the file was not part of any crate's module tree and was never compiled. The canonical versions of the types live infusillade-core/src/daemon_record/types.rs(re-exported viafusillade/src/daemon/mod.rsand consumed byfusillade-arsenalanddwctl), and live private copies of the helpers exist infusillade/src/daemon/mod.rs. The file was left behind when the daemon-record types were extracted tofusillade-corein the workspace integration.fusilladeis markedpublish = false, andcargo check --workspace --all-featuresplus the fusillade/fusillade-core daemon test suites pass after removal.History
Detail: Dead Code
Dead Code PRs can be configured here.