Skip to content

chore(fusillade): remove orphaned daemon types module - #1709

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-fusillade-remove-orphaned-daemon-types-modul-387eda
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-fusillade-remove-orphaned-daemon-types-modul-387eda

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Remove the orphaned fusillade/src/daemon/types.rs file (200 LOC), which declared the typestate daemon record types (DaemonState, DaemonRecord, DaemonData, Initializing, Running, Dead, DaemonStats, AnyDaemonRecord, DaemonStatus, and get_hostname/get_pid/get_version helpers).

The file was dead: fusillade/src/daemon/mod.rs never declares mod types;, so the file was not part of any crate's module tree and was never compiled. The canonical versions of the types live in fusillade-core/src/daemon_record/types.rs (re-exported via fusillade/src/daemon/mod.rs and consumed by fusillade-arsenal and dwctl), and live private copies of the helpers exist in fusillade/src/daemon/mod.rs. The file was left behind when the daemon-record types were extracted to fusillade-core in the workspace integration.

fusillade is marked publish = false, and cargo check --workspace --all-features plus the fusillade/fusillade-core daemon test suites pass after removal.

History

Detail: Dead Code


Dead Code PRs can be configured here.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploying control-layer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59df7cc
Status: ✅  Deploy successful!
Preview URL: https://763db673.control-layer.pages.dev
Branch Preview URL: https://detail-dead-code-chore-fusil.control-layer.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant