chore: remove orphaned daemon transitions module - #1708
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
a9f6b82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd6bb920.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-remov-e29b.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
fusillade/src/daemon/transitions.rs(380 lines), an orphaned filethat was never part of the crate's module tree:
daemon/mod.rsdeclares nomod transitions;(onlyadaptive_concurrency,config,memory_gate,and inline
tests), there is no#[path=...]redirect, and nouseorpub usereferences it. Itsuse super::types::{...}import wouldn't evenresolve if attached.
It was a stale byte-for-byte duplicate of the live implementation in
fusillade-core/src/daemon_record/transitions.rs, left behind when thedaemon lifecycle types moved to
fusillade-core. The production call sitesin
daemon/mod.rs:2879/2942/2974resolve to thefusillade-coretypesre-exported at
daemon/mod.rs:37-40, not to this file.The substantive state-transition logic (the
start/heartbeat/shutdownimpl blocks, lines 7-65) is identical between this file and the live
fusillade-corecopy; the only delta was incidental test-only mock stubs(
purge_orphaned_rows,purge_model_filter_events) added to satisfy anevolved
DaemonStoragetrait.Verification:
cargo check --workspace --all-featurespasses; the 85daemon::lib tests pass.History
Dead Code PRs can be configured here.