Skip to content

chore: remove orphaned daemon transitions module - #1708

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-orphaned-daemon-transitions-module-d5868e
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-orphaned-daemon-transitions-module-d5868e

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Removes fusillade/src/daemon/transitions.rs (380 lines), an orphaned file
that was never part of the crate's module tree: daemon/mod.rs declares no
mod transitions; (only adaptive_concurrency, config, memory_gate,
and inline tests), there is no #[path=...] redirect, and no use or
pub use references it. Its use super::types::{...} import wouldn't even
resolve if attached.

It was a stale byte-for-byte duplicate of the live implementation in
fusillade-core/src/daemon_record/transitions.rs, left behind when the
daemon lifecycle types moved to fusillade-core. The production call sites
in daemon/mod.rs:2879/2942/2974 resolve to the fusillade-core types
re-exported at daemon/mod.rs:37-40, not to this file.

The substantive state-transition logic (the start/heartbeat/shutdown
impl blocks, lines 7-65) is identical between this file and the live
fusillade-core copy; the only delta was incidental test-only mock stubs
(purge_orphaned_rows, purge_model_filter_events) added to satisfy an
evolved DaemonStorage trait.

Verification: cargo check --workspace --all-features passes; the 85
daemon:: lib tests pass.

History


Dead Code PRs can be configured here.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploying control-layer with  Cloudflare Pages  Cloudflare Pages

Latest commit: a9f6b82
Status: ✅  Deploy successful!
Preview URL: https://cd6bb920.control-layer.pages.dev
Branch Preview URL: https://detail-dead-code-chore-remov-e29b.control-layer.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant