chore(dwctl): remove unused get_realtime_api_key test helper - #1707
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
96cb343
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8bc24c3d.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-dwctl-scju.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
get_realtime_api_keyhelper and its two write-only call sitesin the
sla.rsend-to-end escalation tests. The function created a hiddenrealtime API key for the user, but its return value was bound to
_user_realtime_api_keyand never read. The batch daemon uses the batchAPI key from the request template (
request_data.api_key) for HTTP calls,not a separate realtime key — confirmed by the similar
zdr_sentinel.rsbatch E2E test running without a realtime key. The helper was only used in
tests, the variable has been write-only since introduction, and the
..DaemonConfig::default()cascade leaves no orphaned code behind.History
Dead Code PRs can be configured here.