chore: remove unused TaskState weak-ref fields for create-batch and cascade-batch-state - #1706
Open
detail-app[bot] wants to merge 1 commit into
Conversation
…ascade-batch-state
Deploying control-layer with
|
| Latest commit: |
38d4154
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9b09248.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-remov-h45f.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the dead
TaskState::create_batch_jobandTaskState::cascade_batch_state_jobweak-ref fields, their
get_create_batch_job/get_cascade_batch_state_jobgetters,the
OnceLock::setwrites inTaskRunner::new, and the corresponding initializersacross all
TaskState { ... }construction sites (1 production + 6 test sites).These weak-ref fields and getters had no production or test consumers. Production
enqueue paths reach into the strong
Arc<Job>fields onTaskRunnerdirectly(
state.task_runner.create_batch_job.enqueue(...)andstate.task_runner.cascade_batch_state_job), bypassing the weak-ref accessorsentirely. The cross-job enqueue pattern described in their doc comments was never
wired up.
This is a connected dead cluster: each field was read only by its getter, and each
getter had zero call-sites anywhere in the codebase.
History
Dead Code PRs can be configured here.