chore: remove unused inject_into_sse_body and scrub_sse_body wrappers - #1704
Open
detail-app[bot] wants to merge 2 commits into
Open
detail-app[bot] wants to merge 2 commits into
detail-app[bot] wants to merge 2 commits into
Conversation
Deploying control-layer with
|
| Latest commit: |
5775029
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af428e92.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-remov-xver.control-layer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two
pubthin-wrapper functions indwctl/src/prompt_cache/inject.rsthat had no production callers anywhere in the workspace:
inject_into_sse_body: wrappedscan_edit_sse(_, UsageEdit::Inject(stats)).rewrittenscrub_sse_body: wrappedscan_edit_sse(_, UsageEdit::Scrub).rewrittenThe production streaming path (
prompt_cache/layer.rs) callsscan_edit_ssedirectly with the appropriate
UsageEditvariant, bypassing both wrappers — asinject_into_sse_body's own doc comment already noted. Neither was re-exportedfrom
prompt_cache/mod.rs,dwctlispublish = falseand no other workspacecrate depends on it, so there is no external-consumer risk. Git history confirms
neither wrapper ever had a production caller.
Test call sites that referenced the wrappers are retargeted to call
scan_edit_ssedirectly with the equivalentUsageEditvariant, preservingevery test scenario (CRLF framing,
data:/data:prefixes, terminal-frame-onlyedits, scrub zeroing, no-op-when-clean).
History
Dead Code PRs can be configured here.