chore: remove unused tool-loop and parse_chat_chunk helpers from Responses streaming - #1703
Open
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
5a0c86f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a24faae3.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-remov-bdel.control-layer.pages.dev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
StreamingState::extract_tool_calls,StreamingState::prepare_next_iteration,the standalone
parse_chat_chunkparser, and thecreate_tool_call_chunktesthelper plus their unit tests from
dwctl/src/inference/translation/responses/streaming.rs.These were leftovers of the server-side multi-step tool-loop feature retired in #1518
("feat!: remove tool injection, tool_sources, and the onwards Responses adapter").
The dwctl Responses translator is single-pass via
ResponsesStreamReframer, whichonly ever calls
StreamingState::new,process_chunk,finalize, andStreamingEvent::to_sse. After #1518 dropped the only production call-sites (in theonwards Responses adapter), these symbols had no production callers; only their own
in-file
#[cfg(test)]tests referenced them.Dead Code PRs can be configured here.