Skip to content

chore: remove unused TranslationRegistry::default and is_empty - #1695

Merged
JoshC8C7 merged 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-translationregistry-default-an-a751ba
Sep 15, 2026
Merged

JoshC8C7 merged 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-translationregistry-default-an-a751ba

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Remove the unused impl Default for TranslationRegistry and
TranslationRegistry::is_empty method from the edge translation layer.

Both symbols have no callers in production or tests. The registry is
always constructed via TranslationRegistry::new(...) and never through
Default::default() / ..Default::default(), and is_empty is never
read (the is_empty matches in middleware.rs are on Vec<u8>/&str,
not on the registry). dwctl is publish = false with no workspace
consumers, so there are no external callers either.

History


Dead Code PRs can be configured here.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploying control-layer with  Cloudflare Pages  Cloudflare Pages

Latest commit: afa5cf5
Status: ✅  Deploy successful!
Preview URL: https://db2647ef.control-layer.pages.dev
Branch Preview URL: https://detail-dead-code-chore-remov-1r2f.control-layer.pages.dev

View logs

@detail-app
detail-app Bot requested a review from JoshC8C7 September 7, 2026 00:34
@JoshC8C7
JoshC8C7 enabled auto-merge (squash) September 15, 2026 15:31
@detail-app
detail-app Bot force-pushed the detail/dead-code/chore-remove-unused-translationregistry-default-an-a751ba branch from c96d7fd to afa5cf5 Compare September 15, 2026 19:00
@JoshC8C7
JoshC8C7 merged commit 2358272 into main Sep 15, 2026
24 checks passed
sejori pushed a commit that referenced this pull request Sep 16, 2026
🤖 I have created a release *beep* *boop*
---


##
[11.12.0](v11.11.0...v11.12.0)
(2026-09-16)


### Features

* implicit caching using engine / upstream stats
([#1781](#1781))
([7f2adb4](7f2adb4))


### Bug Fixes

* **analytics:** persist billing writes through outbox
([#1787](#1787))
([7896933](7896933))
* **ci:** track the fusillade-arsenal 4.1.0 and fusillade-core 6.0.0
release baselines
([#1784](#1784))
([b644c6f](b644c6f))
* **retention:** use indexed probes for startup and purge route queries
([#1783](#1783))
([364cf42](364cf42))


### Miscellaneous

* remove unused TranslationRegistry::default and is_empty
([#1695](#1695))
([2358272](2358272))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant