chore(dwctl): remove unused Mode::HttpOnly variant from image_normalizer::walker - #1694
Open
detail-app[bot] wants to merge 1 commit into
Conversation
Deploying control-layer with
|
| Latest commit: |
55ef10c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cafbf367.control-layer.pages.dev |
| Branch Preview URL: | https://detail-dead-code-chore-dwctl-hfiz.control-layer.pages.dev |
detail-app
Bot
force-pushed
the
detail/dead-code/chore-dwctl-remove-unused-mode-httponly-variant-fr-4d2d48
branch
from
October 2, 2026 14:50
0cf3d9c to
55ef10c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Mode::HttpOnlyenum variant (and its match arm inapplies_to, its dedicatedhttp_only_substitutes_http_in_chat_completions_shapetest, its module-doc bullet, and 3 incidentalMode::HttpOnlyreferences in tests that now useMode::All) fromdwctl/src/image_normalizer/walker.rs.Why it was dead:
Mode::HttpOnlyhad zero production call-sites. Every production caller ofsubstitute_with— the realtime middleware (image_normalizer_middleware.rsat lines 188 and 268), the dispatch processor (dispatch_processor.rs:271), and the batch file ingest path (files.rs:371) — passesMode::All(orMode::TokensOnlyat dispatch time). The per-user opt-in that would have selectedMode::HttpOnlyas the default was deliberately removed (0d8b35cc, "The per-user opt-in was unnecessary complexity"); the system-wide posture is nowMode::All. The variant had no remaining production path that could reach it, and its doc-comment ("Used by default for users who haven't opted into full normalisation") was stale and actively misleading.dwctlispublish = falsewith no reverse workspace dependencies, so removing thepubvariant has no external impact.is_http_urlstays alive via theMode::Allarm.History
Dead Code PRs can be configured here.