Skip to content

chore(dwctl): remove unused Mode::HttpOnly variant from image_normalizer::walker - #1694

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-dwctl-remove-unused-mode-httponly-variant-fr-4d2d48
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-dwctl-remove-unused-mode-httponly-variant-fr-4d2d48

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Removes the Mode::HttpOnly enum variant (and its match arm in applies_to, its dedicated http_only_substitutes_http_in_chat_completions_shape test, its module-doc bullet, and 3 incidental Mode::HttpOnly references in tests that now use Mode::All) from dwctl/src/image_normalizer/walker.rs.

Why it was dead: Mode::HttpOnly had zero production call-sites. Every production caller of substitute_with — the realtime middleware (image_normalizer_middleware.rs at lines 188 and 268), the dispatch processor (dispatch_processor.rs:271), and the batch file ingest path (files.rs:371) — passes Mode::All (or Mode::TokensOnly at dispatch time). The per-user opt-in that would have selected Mode::HttpOnly as the default was deliberately removed (0d8b35cc, "The per-user opt-in was unnecessary complexity"); the system-wide posture is now Mode::All. The variant had no remaining production path that could reach it, and its doc-comment ("Used by default for users who haven't opted into full normalisation") was stale and actively misleading. dwctl is publish = false with no reverse workspace dependencies, so removing the pub variant has no external impact. is_http_url stays alive via the Mode::All arm.

History


Dead Code PRs can be configured here.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Deploying control-layer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55ef10c
Status: ✅  Deploy successful!
Preview URL: https://cafbf367.control-layer.pages.dev
Branch Preview URL: https://detail-dead-code-chore-dwctl-hfiz.control-layer.pages.dev

View logs

@detail-app
detail-app Bot requested a review from pjb157 September 7, 2026 00:34
@detail-app
detail-app Bot force-pushed the detail/dead-code/chore-dwctl-remove-unused-mode-httponly-variant-fr-4d2d48 branch from 0cf3d9c to 55ef10c Compare October 2, 2026 14:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant