Skip to content

chore: remove unused ImageNormalizer::read plumbing - #1693

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-imagenormalizer-read-plumbing-c67cc5
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-imagenormalizer-read-plumbing-c67cc5

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Remove the read method from the ImageNormalizer trait and its
implementations (DisabledNormalizer, DefaultImageNormalizer), along
with the cascading ImageStore::read trait method and its three backend
impls (MemoryStore, GcsStore, S3CompatStore) and the two tests
that exercised them.

The read method had no production callers anywhere in the workspace.
Its trait doc comment claimed it was "Used by the dashboard image
endpoint (after authorisation)", but the dashboard endpoint
(GET /admin/api/v1/images/:sha256 in api/handlers/images.rs) uses
sign + a 302 redirect to a short-lived signed URL, deliberately
keeping dwctl off the bytes egress path. The comment actively misleads.
Removing the trait method also made the ImageStore::read impls dead
as a cascade (their only production consumer was
DefaultImageNormalizer::read).

History


Dead Code PRs can be configured here.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploying control-layer with  Cloudflare Pages  Cloudflare Pages

Latest commit: b54b16b
Status: ✅  Deploy successful!
Preview URL: https://3fae6a7e.control-layer.pages.dev
Branch Preview URL: https://detail-dead-code-chore-remov-2any.control-layer.pages.dev

View logs

@detail-app
detail-app Bot requested a review from pjb157 September 7, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant