Skip to content

deps: Moho cd47b48 (the walk cost work) - #434

Merged
doubleailes merged 1 commit into
mainfrom
moho-cd47b48
Oct 30, 2026
Merged

doubleailes merged 1 commit into
mainfrom
moho-cd47b48

Conversation

@doubleailes

Copy link
Copy Markdown
Owner

Bumps Moho 4d63d41 → cd47b48: Moho's walk-cost work.

Moho's changes:

  • path-keyed caches and sets (sdf::PathMap and PathSet);
  • each prim linked to its parent in the retained scene index;
  • the stage index holds each prim's children until a resync;
  • is_a answers remembered per schema registry.

Crust needs no code change. openusd stays d7d2a29, and cargo tree -i moho and -i openusd each show one copy.

Images: scripts/check_images.sh check against the goldens recorded before #431 (16 spp, --indirect-clamp 0): every sample is identical except cornellbox_guided. That sample isn't reproducible from run to run (path guiding; see crust-render/tests/host_facts.rs), and 4 of 5 re-renders on this binary matched its golden bit for bit.

Local gate (Windows): clippy is clean. The workspace tests pass except the three that also fail on unmodified main and are Windows-specific: kept, asset_anchoring and stamp. Linux CI is the check for those.

After merge, Mantle bumps to this Moho with the new crust-render.

🤖 Generated with Claude Code

Moho's path-keyed caches and sets, parent links in the retained index,
children held until a resync, and per-registry is_a answers. No crust
change needed; openusd stays d7d2a29, one copy each of moho and openusd.
Every sample renders identically to the goldens (16 spp, --indirect-clamp
0; cornellbox_guided, not reproducible run to run, matched in 4 of 5
re-renders).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Bump Moho to cd47b48 for walk-cost improvements

⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Pin Moho to cd47b48 to pick up upstream walk-cost improvements.
• Update the lockfile without changing Crust source or OpenUSD's revision.
• Image checks match goldens except for the known nondeterministic guided sample.
Diagram

graph TD
  A["OpenUSD stage"] --> B["Moho scene index"] --> C["Crust scene import"] --> D["Crust renderer"]
Loading
High-Level Assessment

Keep the exact Moho revision and matching lockfile source. This takes the upstream improvements without duplicating them in Crust, while preserving a reproducible dependency graph.

Files changed (2) +2 / -2

Other (2) +2 / -2
Cargo.tomlPin Moho to cd47b48 +1/-1

Pin Moho to cd47b48

• Changes the workspace Moho Git revision from 4d63d41 to cd47b48, bringing in upstream walk-cost improvements.

Cargo.toml

Cargo.lockLock the new Moho revision +1/-1

Lock the new Moho revision

• Updates Moho's Git source to cd47b48. No other locked package changes.

Cargo.lock

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@doubleailes
doubleailes merged commit f40e8a3 into main Oct 30, 2026
13 checks passed
@doubleailes
doubleailes deleted the moho-cd47b48 branch October 30, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant