Repository navigation
deps: Moho cd47b48 (the walk cost work) - #434
Merged
Merged
Conversation
Moho's path-keyed caches and sets, parent links in the retained index, children held until a resync, and per-registry is_a answers. No crust change needed; openusd stays d7d2a29, one copy each of moho and openusd. Every sample renders identically to the goldens (16 spp, --indirect-clamp 0; cornellbox_guided, not reproducible run to run, matched in 4 of 5 re-renders). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
PR Summary by QodoBump Moho to cd47b48 for walk-cost improvements
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Moho
4d63d41→cd47b48: Moho's walk-cost work.Moho's changes:
sdf::PathMapandPathSet);is_aanswers remembered per schema registry.Crust needs no code change. openusd stays
d7d2a29, andcargo tree -i mohoand-i openusdeach show one copy.Images:
scripts/check_images.sh checkagainst the goldens recorded before #431 (16 spp,--indirect-clamp 0): every sample is identical exceptcornellbox_guided. That sample isn't reproducible from run to run (path guiding; seecrust-render/tests/host_facts.rs), and 4 of 5 re-renders on this binary matched its golden bit for bit.Local gate (Windows): clippy is clean. The workspace tests pass except the three that also fail on unmodified
mainand are Windows-specific:kept,asset_anchoringandstamp. Linux CI is the check for those.After merge, Mantle bumps to this Moho with the new crust-render.
🤖 Generated with Claude Code