Skip to content

doc(PopoverDropdownBase): update CustomClass documentation#8260

Merged
ArgoZhang merged 1 commit into
mainfrom
doc-select
Jul 24, 2026
Merged

doc(PopoverDropdownBase): update CustomClass documentation#8260
ArgoZhang merged 1 commit into
mainfrom
doc-select

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Jul 24, 2026

Copy link
Copy Markdown
Member

Link issues

fixes #8259

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Documentation:

  • Update the PopoverDropdownBase CustomClass XML documentation in both Chinese and English to explain its implementation via data-bs-custom-class.

@sourcery-ai

sourcery-ai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Clarifies the documentation for the PopoverDropdownBase CustomClass parameter by explicitly stating that it is implemented via the Bootstrap data-bs-custom-class attribute, in both Chinese and English XML comments.

File-Level Changes

Change Details Files
Clarified how the CustomClass parameter is implemented in PopoverDropdownBase XML documentation comments.
  • Updated the Chinese XML documentation to mention that CustomClass is implemented via data-bs-custom-class while keeping default value description.
  • Updated the English XML documentation to mention that CustomClass is implemented via data-bs-custom-class while keeping default value description.
  • Removed the separate remarks tag and merged its information into the main summary comments.
src/BootstrapBlazor/Components/DateTimePicker/PopoverDropdownBase.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8259 Update the PopoverDropdownBase.CustomClass property documentation to clearly describe how the custom class is applied/implemented.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang ArgoZhang self-assigned this Jul 24, 2026
@ArgoZhang ArgoZhang added this to the v10.8.0 milestone Jul 24, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
ArgoZhang merged commit b30c523 into main Jul 24, 2026
5 checks passed
@ArgoZhang
ArgoZhang deleted the doc-select branch July 24, 2026 00:56
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a1b5d20) to head (1b349ab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          769       769           
  Lines        34436     34436           
=========================================
  Hits         34436     34436           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc(PopoverDropdownBase): update CustomClass documentation

1 participant