Skip to content

Fix broken icons across the site#156

Merged
djoufson merged 2 commits into
mainfrom
fix-icons
Jun 7, 2026
Merged

Fix broken icons across the site#156
djoufson merged 2 commits into
mainfrom
fix-icons

Conversation

@djoufson

@djoufson djoufson commented Jun 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Add the missing Font Awesome stylesheet — fa-solid, fa-regular and fa-brands icons are used across Contact, Events, Login, Jobs, Error and the .NET Conf pages but no CSS was ever loaded for them.
  • Properly escape the second @ in the Phosphor CDN URLs (web@@2.1.1) and switch to jsdelivr so the version segment is reliably preserved through Razor parsing.
  • Scope the default font-family / font-weight rule to text elements (body, p, span, ul, li, h1..h4) instead of *, ::before, ::after, .... The wildcard rule was setting font-family: Lexend directly on ::before pseudo-elements, which overrode the icon fonts ("Phosphor", "Font Awesome ...") on the very pseudo-element that renders the glyph — so icons rendered as tofu boxes.
  • Same scoping for the default text-dark-purple color rule, so icon colors can inherit from their parent (e.g. <a class="text-primary"><i class="ph ph-..."></i></a> now works).

Test plan

  • Hard-refresh the home page — Phosphor icons (arrows, whatsapp, github, globe, hearts, etc.) render correctly
  • Contact page — fa-brands (discord, linkedin, github, whatsapp, telegram) render
  • Jobs pages — fa-solid / fa-brands icons render
  • Error and .NET Conf 2024/2025 pages — FontAwesome icons render
  • Icons inside text-primary / text-white / etc. containers inherit the parent color

🤖 Generated with Claude Code

@djoufson djoufson merged commit aab7dee into main Jun 7, 2026
1 check passed
@djoufson djoufson deleted the fix-icons branch June 7, 2026 08:18
@djoufson djoufson self-assigned this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant