Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fa-solid,fa-regularandfa-brandsicons are used across Contact, Events, Login, Jobs, Error and the .NET Conf pages but no CSS was ever loaded for them.@in the Phosphor CDN URLs (web@@2.1.1) and switch to jsdelivr so the version segment is reliably preserved through Razor parsing.font-family/font-weightrule to text elements (body, p, span, ul, li, h1..h4) instead of*, ::before, ::after, .... The wildcard rule was settingfont-family: Lexenddirectly on::beforepseudo-elements, which overrode the icon fonts ("Phosphor","Font Awesome ...") on the very pseudo-element that renders the glyph — so icons rendered as tofu boxes.text-dark-purplecolor rule, so icon colors can inherit from their parent (e.g.<a class="text-primary"><i class="ph ph-..."></i></a>now works).Test plan
fa-brands(discord, linkedin, github, whatsapp, telegram) renderfa-solid/fa-brandsicons rendertext-primary/text-white/ etc. containers inherit the parent color🤖 Generated with Claude Code