Skip to content

fix(analyzers): exclude operators from CA1822 false positive #54517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EduardF1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(analyzers): exclude operators from CA1822 false positive #54517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...sis.NetAnalyzers/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStatic.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,14 @@ private static bool ShouldAnalyze(
return false;
}

// Do not analyze operator methods. Regular operators are already required to be static in C#.
// C# 14 compound assignment operators (e.g. operator +=) are required to be instance methods
// and cannot be made static, so flagging them is a false positive.
if (methodSymbol.MethodKind is MethodKind.UserDefinedOperator or MethodKind.Conversion)
{
return false;
}

// Don't report methods which have a single throw statement
// with NotImplementedException or NotSupportedException
if (context.IsMethodNotImplementedOrSupported())
Expand Down
Loading