Tune Helix partitioning: TargetOS/TargetArchitecture and NetAnalyzers multiplier#54512
Open
MichaelSimons wants to merge 1 commit into
Open
Tune Helix partitioning: TargetOS/TargetArchitecture and NetAnalyzers multiplier#54512MichaelSimons wants to merge 1 commit into
MichaelSimons wants to merge 1 commit into
Conversation
…Analyzers multiplier
- Replace TargetRid.StartsWith('osx-arm64') with TargetOS/TargetArchitecture
condition for clearer, more explicit platform detection
- Increase NetAnalyzers MethodLimitMultiplier from 5 to 10, reducing its
Windows partitions from ~41 to ~21 work items (targeting 5min/item)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tunes Helix unit-test work item partitioning by making macOS arm64 detection more explicit and reducing over-partitioning for NetAnalyzers tests.
Changes:
- Uses
TargetOSandTargetArchitectureinstead of parsingTargetRidfor macOS arm64 partition sizing. - Increases NetAnalyzers
MethodLimitMultiplierfrom 5 to 10 to create fewer, larger Helix work items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #54502. Two tuning changes for Helix work item partitioning:
*Replace \TargetRid.StartsWith('osx-arm64')\ with \TargetOS/\TargetArchitecture* — clearer, more explicit platform detection using properties that are already available in the evaluation context.
Bump NetAnalyzers \MethodLimitMultiplier\ from 5 to 10 — NetAnalyzers was over-partitioned (41 work items on Windows with total time of ~104 min). Doubling the multiplier targets ~21 parts at ~5 min/item, saving ~20 work items on Windows alone.
Projected Impact (Windows)
This is additive to the 62% reduction achieved in #54502.