[wasm][R2R] Re-enable open virtual delegate runtime tests - #134765
Merged
lewing merged 1 commit intoSep 28, 2026
Merged
Conversation
Runtime_79354 and Runtime_70259 were disabled on wasm ReadyToRun because invoking an open virtual delegate from R2R code hit portableEntryPoint->IsValid() in the interpreted delegate shuffle thunk. #134699 fixed that, so remove the ActiveIssue attributes and the TestLibrary references that were only needed for them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
jkotas
approved these changes
Sep 28, 2026
lewing
enabled auto-merge (squash)
September 28, 2026 01:58
steveisok
approved these changes
Sep 28, 2026
lewing
deleted the
lewing-wasm-r2r-reenable-open-virtual-delegate-tests
branch
September 28, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables two JIT regression tests that were disabled on browser-wasm ReadyToRun. Both invoke an open delegate over an interface method from R2R-compiled code. Before #134699, that hit
portableEntryPoint->IsValid()in the interpreted delegate shuffle thunk, because the thunk'scallipassedCID_VirtualOpenDelegateDispatchtoPortableEntryPoint::GetMethodDesc.JIT/Regression_o_3/Runtime_79354:ActiveIssuefor Wasm: Runtime_79354 fails with test assembly R2R #131886 removed.JIT/Regression_2/Runtime_70259(.csand.il):ActiveIssuefor [wasm][R2R] Runtime_70259 asserts in ToPortableEntryPoint #133169, a duplicate of Wasm: Runtime_79354 fails with test assembly R2R #131886, removed.TestLibraryusing/assembly reference is also removed from each file, since it was only there for these attributes. [wasm][coreclr] Fix call delegate with IL stubs #125138 did the same when it last re-enabled these tests.Validation (local)
Run on browser-wasm with a checked runtime, Release libraries and crossgen2 ReadyToRun (
RunCrossGen2=1), matching theR2R_CG2 browser wasm checkedlane. The R2R images were emitted and loaded.INTOP_CALLIbranch disabledRuntime_79354portableEntryPoint->IsValid()inMyDelegate::IL_STUB_DelegateShuffleThunk, IR_0014Runtime_70259portableEntryPoint->IsValid()inSystem.Func`2[__Canon,Int32]::IL_STUB_DelegateShuffleThunk, IR_0014I also checked the separate diagnosis in #130840 (a misplaced receiver in
INTOP_CALLDELEGATE's open-virtual branch after R2R-to-interpreter entry). A scratch probe had R2R-compiled callers invoke interpretedDynamicMethods, which then invoke open virtual delegates. It covered interface and class-virtual targets, class and boxed-struct receivers, mixed int/long/double arguments, aVector128argument and a hidden-buffer struct return. AllINTOP_CALLDELEGATEcases passed, including with #134699's branch disabled. Details are in #130840.Resolves #131886
Resolves #130840
Note
This PR description was generated with GitHub Copilot.