Add fast path for Overlaps when other is IReadOnlySet with fast lookup and same equality comparer #132763 - #134726
Open
Advitalitum wants to merge 6 commits into
Open
Advitalitum wants to merge 6 commits into
Advitalitum wants to merge 6 commits into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
lilinus
reviewed
Sep 27, 2026
| return false; | ||
| } | ||
|
|
||
| private static bool SmallerFrozenSetOverlapsLargerCompatibleReadOnlySetImpl(FrozenSet<T> smaller, IReadOnlySet<T> larger) |
Contributor
There was a problem hiding this comment.
Why not just have one method and switch arguments at call-site to keep it simpler?
Contributor
Author
There was a problem hiding this comment.
I think it can be done for ISet as arguments, just need to duplicate method ComparersAreCompatible for ISet, but Immutable collections don't implement ISet
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #132763
In FrozenSet.Overlaps(IEnumerable other) when other is IReadOnlySet with fast lookup and same comparer, we should iterate through the smaller set and search within the larger one.
// Benchmarks in progress