Name resolution: CheckIWSAM only needs the intrinsic methods - #20490
Open
auduchinok wants to merge 1 commit into
Open
Name resolution: CheckIWSAM only needs the intrinsic methods#20490auduchinok wants to merge 1 commit into
auduchinok wants to merge 1 commit into
Conversation
AllMethInfosOfTypeInScope is IntrinsicMethInfosOfType @ ExtensionMethInfosOfTypeInScope, and with AllResults the extension half always runs, but the predicate discards every extension member it finds. Call IntrinsicMethInfosOfType directly with the arguments AllMethInfosOfTypeInScope passed it, which also drops the NameEnv only the extension scan needed. It is exported from the signature rather than substituting InfoReader.GetIntrinsicMethInfosOfType, which does not apply ExcludeHiddenOfMethInfos. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev Caution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository: `* . (PR #XXXXX)`
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.
|
github-actions
Bot
added
the
AI-Tooling-Check-Scanned-Clean
github-project-automation
Bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
self-requested a review
September 9, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckIWSAMwarns when an interface carrying static abstract members is used as a type. It askedAllMethInfosOfTypeInScopefor every method of the type, which isIntrinsicMethInfosOfType @ ExtensionMethInfosOfTypeInScope, and withResultCollectionSettings.AllResultsthe extension half always runs. The predicate then discards all of it through
not meth.IsExtensionMember.This calls
IntrinsicMethInfosOfTypedirectly with the argumentsAllMethInfosOfTypeInScopepassed it.