Preserve resumable state-machine lowering in Debug - #20469
Draft
majocha wants to merge 3 commits into
Draft
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
Contributor
Author
|
The idea is to preserve the exact behavior of from before #19548. Resumable code lowers to static branch whenever possible even in debug. |
Contributor
Author
|
This is AI generated and clearly fails regression tests. |
Member
This is a break we can take in order to make the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20466
Debug compilation could route inline builders containing low-level resumable state machines through generated helper methods. That helper boundary hid nested
ResumableCodedefinitions from lowering, causing incorrect execution for composed builders such asTaskSeq. Keep resumable inline expansions in the caller's expression tree while preserving the existing helper specialization for ordinary inline methods.