Fix broken string interpolation in LlvmIrInstructions error messages#11431
Open
Copilot wants to merge 3 commits into
Open
Fix broken string interpolation in LlvmIrInstructions error messages#11431Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
5 tasks
Agent-Logs-Url: https://github.com/dotnet/android/sessions/b8dbee6b-c452-44fd-a586-1d0010f4a375 Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix broken string interpolation in LlvmIrInstructions error messages
Fix broken string interpolation in LlvmIrInstructions error messages
May 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two internal error message strings in the LLVM IR generator so they correctly interpolate values (and have balanced quotes), improving diagnosability of generator failures.
Changes:
- Corrected string interpolation for
cond.TypeinBrvalidation error. - Fixed missing closing quote around
{function.Signature.ReturnType}inCallvalidation error.
Comment on lines
219
to
222
| if (function.Signature.ReturnType != typeof(void)) { | ||
| if (result == null) { | ||
| throw new ArgumentNullException ($"Internal error: function '{function.Signature.Name}' returns '{function.Signature.ReturnType} and thus requires a result variable", nameof (result)); | ||
| throw new ArgumentNullException ($"Internal error: function '{function.Signature.Name}' returns '{function.Signature.ReturnType}' and thus requires a result variable", nameof (result)); | ||
| } |
The ArgumentNullException(string? paramName, string? message) constructor takes paramName first and message second. Both call sites had them swapped, which would produce confusing exceptions where ParamName was the full English sentence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two error messages in
LlvmIrInstructions.cshave broken string interpolation:{}aroundcond.Type— prints literal text instead of the variable value'after{function.Signature.ReturnType}interpolation