Light Freshness Edit: ASP.NET - mvc#37085
Open
lootle1 wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
Contributor
Author
|
@tdykstra @wadepickett this PR is ready for review. Top comment has an overview. Note I ran into an issue on the previous PR (also in top comment) so pushed all those changes here along with the new ones. Let me know if any additional change requests, thank you! |
wadepickett
reviewed
Apr 30, 2026
| ## More view features | ||
|
|
||
| [Tag Helpers](xref:mvc/views/tag-helpers/intro) make it easy to add server-side behavior to existing HTML tags. Using Tag Helpers avoids the need to write custom code or helpers within your views. Tag helpers are applied as attributes to HTML elements and are ignored by editors that can't process them. This allows you to edit and render view markup in a variety of tools. | ||
| [Tag Helpers](xref:mvc/views/tag-helpers/intro) make it easy to add server-side behavior to existing HTML tags. Using Tag Helpers avoids the need to write custom code or helpers within your views. Tag helpers are applied as attributes to HTML elements and editors that can't process them ignore them. This allows you to edit and render view markup in a variety of tools. |
Contributor
There was a problem hiding this comment.
Suggested change
| [Tag Helpers](xref:mvc/views/tag-helpers/intro) make it easy to add server-side behavior to existing HTML tags. Using Tag Helpers avoids the need to write custom code or helpers within your views. Tag helpers are applied as attributes to HTML elements and editors that can't process them ignore them. This allows you to edit and render view markup in a variety of tools. | |
| [Tag Helpers](xref:mvc/views/tag-helpers/intro) make it easy to add server-side behavior to existing HTML tags. Using Tag Helpers avoids the need to write custom code or helpers within your views. Tag helpers are applied as attributes to HTML elements and are ignored by editors that can't process them. This allows you to edit and render view markup in a variety of tools. |
Minor item: "them ignore them" seemed a bit awkward. See if you think this is better.
wadepickett
reviewed
Apr 30, 2026
| [!code-cshtml[](../../common/samples/WebApplication1/Views/Home/About.cshtml)] | ||
|
|
||
| [Razor markup](xref:mvc/views/razor) starts with the `@` symbol. Run C# statements by placing C# code within [Razor code blocks](xref:mvc/views/razor#razor-code-blocks) set off by curly braces (`{ ... }`). For example, see the assignment of "About" to `ViewData["Title"]` shown above. You can display values within HTML by simply referencing the value with the `@` symbol. See the contents of the `<h2>` and `<h3>` elements above. | ||
| [Razor markup](xref:mvc/views/razor) starts with the `@` symbol. Run C# statements by placing C# code within [Razor code blocks](xref:mvc/views/razor#razor-code-blocks) set off by curly braces (`{ ... }`). For example, see the assignment of "About" to `ViewData["Title"]` shown previously. You can display values within HTML by simply referencing the value with the `@` symbol. See the contents of the `<h2>` and `<h3>` elements previous. |
Contributor
There was a problem hiding this comment.
Suggested change
| [Razor markup](xref:mvc/views/razor) starts with the `@` symbol. Run C# statements by placing C# code within [Razor code blocks](xref:mvc/views/razor#razor-code-blocks) set off by curly braces (`{ ... }`). For example, see the assignment of "About" to `ViewData["Title"]` shown previously. You can display values within HTML by simply referencing the value with the `@` symbol. See the contents of the `<h2>` and `<h3>` elements previous. | |
| [Razor markup](xref:mvc/views/razor) starts with the `@` symbol. Run C# statements by placing C# code within [Razor code blocks](xref:mvc/views/razor#razor-code-blocks) set off by curly braces (`{ ... }`). For example, see the assignment of "About" to `ViewData["Title"]` shown previously. You can display values within HTML by simply referencing the value with the `@` symbol. See the contents of the `<h2>` and `<h3>` elements previously. |
Minor item: "previous" to "previously".
wadepickett
reviewed
Apr 30, 2026
| > Controllers shouldn't be overly complicated by too many responsibilities. To keep controller logic from becoming overly complex, push business logic out of the controller and into the domain model. | ||
|
|
||
| > | ||
| >[!TIP] |
Contributor
There was a problem hiding this comment.
Suggested change
| >[!TIP] | |
| > [!TIP] |
Minor: space was missing.
wadepickett
reviewed
Apr 30, 2026
|
|
||
| * The "int" element wasn't closed. All elements must be either self-closing or have a matching end tag. | ||
| * Cannot convert method group 'GenericMethod' to non-delegate type 'object'. Did you intend to invoke the method?` | ||
| * Can't convert method group 'GenericMethod' to non-delegate type 'object'. Did you intend to invoke the method?` |
Contributor
There was a problem hiding this comment.
Suggested change
| * Can't convert method group 'GenericMethod' to non-delegate type 'object'. Did you intend to invoke the method?` | |
| * Cannot convert method group 'GenericMethod' to non-delegate type 'object'. Did you intend to invoke the method?` |
Compiler error messages are verbatim output from the C# compiler and should not be altered for style.
wadepickett
requested changes
Apr 30, 2026
Contributor
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
Looks great! I found a few small item and one medium one to fix before we merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains freshness updates to the following articles:
[Answered by Wade in other now closed PR here pushed to this PR] Row 119, the link https://jqueryvalidation.org/ goes to a page with an invalid SSL and host error. Perhaps they're in the process of updating but curious if you want to remove, replace, or leave as is? I did search for a replacement in case we want to replace but didn't locate anything.
Minor grammar/style updates. Link updates.
For request details, see 568764
Internal previews