[Pre4] New JavaScript interop features#35220
Merged
Conversation
This was referenced Apr 14, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
oroztocil
requested changes
Apr 15, 2025
Member
oroztocil
left a comment
oroztocil
left a comment
There was a problem hiding this comment.
Looks great. Please remove the lines about the unused GetValue overload and decide about the other proposals. Thanks!
guardrex
commented
Apr 15, 2025
Collaborator
Author
|
Thanks @oroztocil ... Updates made! 🍻 |
oroztocil
reviewed
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35219
Addresses #34437
@oroztocil ... ready for review. 🎉
Internal previews