Skip to content

Updated the incorrect list bullets#35154

Merged
guardrex merged 6 commits intodotnet:mainfrom
benhopkinstech:list-bullets
Apr 5, 2025
Merged

Updated the incorrect list bullets#35154
guardrex merged 6 commits intodotnet:mainfrom
benhopkinstech:list-bullets

Conversation

@benhopkinstech
Copy link
Copy Markdown
Contributor

@benhopkinstech benhopkinstech commented Apr 5, 2025

Fixed the incorrect list bullets in the YARP node and other places across the repository


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
.github/ISSUE_TEMPLATE/doc-request.md .github/ISSUE_TEMPLATE/doc-request
aspnetcore/data/ef-rp/intro/samples/cu/wwwroot/lib/bootstrap/ISSUE_TEMPLATE.md aspnetcore/data/ef-rp/intro/samples/cu/wwwroot/lib/bootstrap/ISSUE_TEMPLATE
aspnetcore/data/scaffold_RP.md aspnetcore/data/scaffold_RP
aspnetcore/fundamentals/apis.md aspnetcore/fundamentals/apis
aspnetcore/fundamentals/minimal-apis/security.md aspnetcore/fundamentals/minimal-apis/security
aspnetcore/fundamentals/portable-object-localization.md aspnetcore/fundamentals/portable-object-localization
aspnetcore/fundamentals/servers/yarp/config-filters.md aspnetcore/fundamentals/servers/yarp/config-filters
aspnetcore/fundamentals/servers/yarp/config-providers.md aspnetcore/fundamentals/servers/yarp/config-providers
aspnetcore/fundamentals/servers/yarp/destination-resolvers.md aspnetcore/fundamentals/servers/yarp/destination-resolvers
aspnetcore/fundamentals/servers/yarp/dests-health-checks.md aspnetcore/fundamentals/servers/yarp/dests-health-checks
aspnetcore/fundamentals/servers/yarp/direct-forwarding.md aspnetcore/fundamentals/servers/yarp/direct-forwarding
aspnetcore/fundamentals/servers/yarp/header-routing.md aspnetcore/fundamentals/servers/yarp/header-routing
aspnetcore/fundamentals/servers/yarp/http-client-config.md aspnetcore/fundamentals/servers/yarp/http-client-config
aspnetcore/fundamentals/servers/yarp/queryparameter-routing.md aspnetcore/fundamentals/servers/yarp/queryparameter-routing
aspnetcore/fundamentals/servers/yarp/transforms.md aspnetcore/fundamentals/servers/yarp/transforms
aspnetcore/migration/inc/session.md aspnetcore/migration/inc/session
aspnetcore/mvc/advanced/custom-model-binding.md aspnetcore/mvc/advanced/custom-model-binding
aspnetcore/performance/diagnostic-tools.md aspnetcore/performance/diagnostic-tools
aspnetcore/performance/rate-limit.md aspnetcore/performance/rate-limit
aspnetcore/release-notes/aspnetcore-1.1.md aspnetcore/release-notes/aspnetcore-1.1
aspnetcore/release-notes/aspnetcore-10.0.md aspnetcore/release-notes/aspnetcore-10.0
aspnetcore/security/anti-request-forgery/samples/2.x/MvcSample/wwwroot/lib/bootstrap/ISSUE_TEMPLATE.md aspnetcore/security/anti-request-forgery/samples/2.x/MvcSample/wwwroot/lib/bootstrap/ISSUE_TEMPLATE
aspnetcore/security/authentication/azure-ad-b2c.md aspnetcore/security/authentication/azure-ad-b2c
aspnetcore/web-api/http-repl/index.md aspnetcore/web-api/http-repl/index
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod1.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod1
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod2.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod2
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod3.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod3
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod4.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod4
aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod5.md aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod5

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

@benhopkinstech benhopkinstech requested a review from tdykstra as a code owner April 5, 2025 13:52
@benhopkinstech
Copy link
Copy Markdown
Contributor Author

@guardrex

I have done this as per your guidelines if you could kindly review 😊

@guardrex guardrex self-assigned this Apr 5, 2025
Copy link
Copy Markdown
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benhopkinstech! 🎸 ... The unpaired bullets bother me and aren't recommended by our style manual or Chicago, but I know that Rick doesn't care about them. I converted some of the lingering dashes to asterisks, but there are too many to do one at a time using the diff, so I'm going to edit some of the files manually after the next commit.

Comment thread aspnetcore/data/scaffold_RP.md
Comment thread aspnetcore/fundamentals/openapi/include-metadata.md
Comment thread aspnetcore/fundamentals/portable-object-localization.md
Comment thread aspnetcore/fundamentals/portable-object-localization.md
Comment thread aspnetcore/fundamentals/portable-object-localization.md
Comment thread aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md Outdated
Comment thread aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md Outdated
Comment thread aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md Outdated
Comment thread aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md Outdated
Comment thread aspnetcore/whats-new/dotnet-AspNetCore.Docs-mod0.md Outdated
Copy link
Copy Markdown
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW ... The What's New ones are automatically generated, so they don't really matter. The articles tho should use asterisks.

WRT the one-item bullet lists, I'm personally not a fan, and the entire Blazor node avoids them, but I think the other doc authors here don't care too much about them.

@benhopkinstech
Copy link
Copy Markdown
Contributor Author

benhopkinstech commented Apr 5, 2025

Thanks @benhopkinstech! 🎸 ... The unpaired bullets bother me and aren't recommended by our style manual or Chicago, but I know that Rick doesn't care about them. I converted some of the lingering dashes to asterisks, but there are too many to do one at a time using the diff, so I'm going to edit some of the files manually after the next commit.

Apologies, I had intentionally left them as I thought the indented bullet points were to use -. I just followed this from something I saw somewhere in the repo.

@guardrex
Copy link
Copy Markdown
Collaborator

guardrex commented Apr 5, 2025

The original rule from many years ago for this repo was just to only use asterisks, but that's slipped a bit here and there over the years. The auto-generated files aren't using them. It's not a big deal really.

@guardrex guardrex merged commit 09f5757 into dotnet:main Apr 5, 2025
3 checks passed
@benhopkinstech benhopkinstech deleted the list-bullets branch April 5, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants