Fix Page Scanner URL host resolution for traditional pages in UVE#35649
Draft
Copilot wants to merge 4 commits into
Draft
Fix Page Scanner URL host resolution for traditional pages in UVE#35649Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
5 tasks
Copilot
AI
changed the title
[WIP] Fix Page Scanner URL for traditional pages
Fix Page Scanner URL host resolution for traditional pages in UVE
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Traditional pages were sending scanner URLs as
admin-origin + path, which made same-path pages across different hosts indistinguishable and produced reports for the wrong page. This update makes scanner URL construction host-aware for traditional pages while preserving headless behavior.getRequestHostNameto resolve in this order:params.clientHost(headless, unchanged)site.hostname(traditional pages)window.location.originfallbackDotEmaShellComponent$seoParamsto passpageAsset.site.hostnameinto host resolution so both Geo and A11y scanner flows receive the correct page host.clientHostprecedence$seoParams.requestHostNameon traditional pages (noclientHost)Checklist
Additional Info
Security/trust boundaries are unchanged: backend proxy behavior is the same; this PR corrects frontend URL selection so scanner requests target the actual edited page host for traditional pages.
Screenshots
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
opencollective.com/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/core/core/core-web/node_modules/document-register-element/node_modules/.bin/lightercollective /home/REDACTED/work/core/core/core-web/libs/portlets/edit-ema/portlet/src/lib/utils/utils.spec.ts(dns block)If you need me to access, download, or install something from one of these locations, you can either: