Fix duplicate chat submits from Enter races and IME composition#2
Open
coconiiruzo wants to merge 1 commit into
Open
Fix duplicate chat submits from Enter races and IME composition#2coconiiruzo wants to merge 1 commit into
coconiiruzo wants to merge 1 commit into
Conversation
Guard submit with a synchronous localTurn ref and ignore Enter while an IME composition is active so one keypress cannot enqueue two agent turns. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localTurnRefupdate so a second Enter/click cannot race ahead of React state and POST a duplicate agent turn.isComposing/ keyCode 229), which is a common Japanese-input footgun in chat composers.Screenshot
One session showing before/after:
Test plan
Local verification:
bun run check— 692 pass, 0 fail (Bun 1.3.14).