i18n: extract authorization screen strings (Part of #145) - #168
Open
everysingletear wants to merge 2 commits into
Open
i18n: extract authorization screen strings (Part of #145)#168everysingletear wants to merge 2 commits into
everysingletear wants to merge 2 commits into
Conversation
Add an `auth` namespace and register it in the i18n config, then move the login screen off hardcoded English: primary and sub-account tabs, the credential form, social and Authentik buttons, the welcome-back state and every auth error toast. Login is the first screen a non-English user ever sees, so it was the most visible gap left in the coverage. Part of donetick#145
Extend the `auth` namespace to the remaining authorization flows: account creation with its field-validation messages, the password reset request, and the new-password entry screen, including all toasts. Completes the authorization zone — no hardcoded user-facing English is left under src/views/Authorization/ apart from MFA verification, which touches other logic and is better handled separately. Part of donetick#145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #145.
Extracts every user-facing string under
src/views/Authorization/into a newauthnamespace. English only — no translations in this PR, so it is language-agnostic and safe to review as a pure refactor.What moves
LoginViewSignupForgotPasswordViewUpdatePasswordViewauthis registered insrc/i18n/config.js;public/locales/en/auth.jsonholds the 75 keys.Why this zone first
Login is the first screen a non-English user ever reaches, and right now it is entirely hardcoded — someone who picks a language in settings still gets an English login screen on their next cold start. It is also self-contained: four files, no shared components, so it does not collide with in-flight work elsewhere.
It should also compose well with the Crowdin setup that just landed on
develop— the config picks up/public/locales/en/*.jsonby glob, so this namespace flows into the translation pipeline with no change tocrowdin.yml.Notes
MFAVerificationModalis deliberately left out — it is entangled with the MFA flow logic and deserves its own pass rather than being smuggled in here.develop; build is green.