Split landing page into its own repo (app-only frontend) - #160
Open
majicmaj wants to merge 2 commits into
Open
Conversation
The marketing landing page has been split into a standalone static Astro site (https://github.com/majicmaj/donetick-landing) for better SEO and performance. This app is now app-only. - Delete src/views/Landing/ (hero, features, demos, footer, etc.) - Simplify RouterContext: root '/' always renders <MyChores/>; drop the donetick.com hostname switch (getMainRoute) and the /welcome route - Remove the landing-only `aos` dependency - Drop the unused VITE_IS_LANDING_DEFAULT env var - Add docs/landing-migration.md + README pointer App build verified (vite build) and no Landing references remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Follow-up to the landing removal — clean up stale landing-era logic the first pass missed: - NavBar: drop '/welcome' from the hidden-navbar routes, remove the donetick.com/www.donetick.com hostname check that suppressed the navbar, and drop '/landing' from publicPages - PageTransition: remove the dead '/landing' route-hierarchy entry and fade-transition check No hostname branching or landing references remain in src; vite build passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the landing page into its own repository
The marketing/landing page has moved out of this app into a standalone, SEO-first static site:
➡️ https://github.com/majicmaj/donetick-landing
This app (
frontend) is now app-only — it renders the user's chores at the root and no longer serves a marketing page on any hostname.Why
The landing page lived inside this SPA and was shown via a hostname check (
donetick.com/www.donetick.com→<Landing/>, everything else → the app). So every visitor to the marketing domain downloaded the whole app bundle (~3 MB JS) just to read a static pitch page, and the initial HTML was an empty<div id="root">with no metadata — bad for SEO and for load performance.The new
donetick-landingis a static Astro site: server-rendered HTML with full meta / OpenGraph / JSON-LD, a sitemap + robots.txt, near-zero JS (one small React island for the interactive assignment demo), and its own independent deploy.What changed here
src/views/Landing/(14 files)donetick-landing.src/contexts/RouterContext.jsx(getMainRoute())/now always renders<MyChores/>./welcomeroute<Landing/>.aosdependencyVITE_IS_LANDING_DEFAULTenv var.env/.env.development./privacyand/terms(their own views) are untouched. Addeddocs/landing-migration.md+ a README pointer.Deployment impact⚠️
app.donetick.com→ still served by this SPA. No change.donetick.com/www.donetick.com→ must now be pointed at thedonetick-landingdeployment (static; buildnpm run build, outputdist/— Cloudflare Pages or any static host). Until repointed,donetick.comserved by this app will show the app (signed-out visitors get/login) instead of the marketing page.Verification
vite buildpasses with the landing code andaosremoved.grepconfirms no remainingviews/Landing/getMainRoute/aosreferences insrc.Notes
develop.majicmaj/donetick-fe) since the landing site now lives undermajicmaj.🤖 Generated with Claude Code