Skip to content

fix: sync AVAILABLE_LANGUAGES with shipped locales (add zh-CN; drop duplicate ja) - #141

Open
everysingletear wants to merge 1 commit into
donetick:developfrom
everysingletear:fix/available-languages
Open

fix: sync AVAILABLE_LANGUAGES with shipped locales (add zh-CN; drop duplicate ja)#141
everysingletear wants to merge 1 commit into
donetick:developfrom
everysingletear:fix/available-languages

Conversation

@everysingletear

@everysingletear everysingletear commented Jul 15, 2026

Copy link
Copy Markdown

What

The language selector reads AVAILABLE_LANGUAGES in
src/contexts/LocalizationContext.jsx, which is out of sync with the locale
files in public/locales/:

Note

Arabic (ar) was in the original version of this PR but has been dropped per
maintainer feedback
— surfacing it activates the existing RTL path
(RTL_LANGUAGES already includes ar), and RTL needs a proper pass first. It
can come back as its own PR once RTL is verified. This PR is now purely the
zh-CN fix + ja de-dup, with no RTL implications.

How to verify

  • The selector lists Chinese (Simplified) and loads its dictionary with no
    missing keys.
  • Japanese appears once, not twice.

@meauxt

meauxt commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

I think we can remove arabic as the RTL seems need more work

…uplicate ja)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@everysingletear
everysingletear force-pushed the fix/available-languages branch from 25d9b92 to f5da57d Compare July 21, 2026 07:58
@everysingletear everysingletear changed the title fix: sync AVAILABLE_LANGUAGES with shipped locales (add ar, zh-CN; drop duplicate ja) fix: sync AVAILABLE_LANGUAGES with shipped locales (add zh-CN; drop duplicate ja) Jul 21, 2026
@everysingletear

Copy link
Copy Markdown
Author

Good call — dropped Arabic and force-pushed. RTL deserves a proper visual pass before we surface ar, so I'll bring it back as its own PR once that's verified. This PR is now just the zh-CN fix + ja de-dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants