fix: sync AVAILABLE_LANGUAGES with shipped locales (add zh-CN; drop duplicate ja) - #141
Open
everysingletear wants to merge 1 commit into
Open
fix: sync AVAILABLE_LANGUAGES with shipped locales (add zh-CN; drop duplicate ja)#141everysingletear wants to merge 1 commit into
everysingletear wants to merge 1 commit into
Conversation
Contributor
|
I think we can remove arabic as the RTL seems need more work |
…uplicate ja) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
everysingletear
force-pushed
the
fix/available-languages
branch
from
July 21, 2026 07:58
25d9b92 to
f5da57d
Compare
Author
|
Good call — dropped Arabic and force-pushed. RTL deserves a proper visual pass before we surface |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The language selector reads
AVAILABLE_LANGUAGESinsrc/contexts/LocalizationContext.jsx, which is out of sync with the localefiles in
public/locales/:zh-CN). It ships a complete translation (keystructure identical to
en) but was unreachable in the selector —zh-CNlanded in feat: Add Simplified Chinese (zh-CN) localization新增简体中文(zh-CN)语言汉化包 #132 without a selector entry.
ja) entry (two merges of the "addJapanese" work each appended one).
Note
Arabic (
ar) was in the original version of this PR but has been dropped permaintainer feedback — surfacing it activates the existing RTL path
(
RTL_LANGUAGESalready includesar), and RTL needs a proper pass first. Itcan come back as its own PR once RTL is verified. This PR is now purely the
zh-CNfix +jade-dup, with no RTL implications.How to verify
missing keys.