Skip to content

eslint@9, prettier - #105

Open
scottanderson wants to merge 2 commits into
donetick:developfrom
scottanderson:eslint
Open

eslint@9, prettier#105
scottanderson wants to merge 2 commits into
donetick:developfrom
scottanderson:eslint

Conversation

@scottanderson

@scottanderson scottanderson commented May 23, 2026

Copy link
Copy Markdown
Contributor

Features

  • Migrate to eslint@9.
    • Migrate various config files to the modern ESM *.config.mjs format, so eslint can detect and handle them correctly.
  • Report eslint errors and warnings as github annotations using eslint-gha-formatter.
    • This CI check is currently disabled. See the steps below to enable it.
    • Annotations will appear in the files view after the github action runs.
  • Add common stylistic and typescript-eslint rules.
    • The chosen settings reflect the existing code style, measured as number of lines affected.
  • Reduce rules with violations to warn.
    • These warnings can be addressed in separate PRs.

Dependencies

This change includes code from:

Next steps

After merging this PR, complete the following steps to enable CI enforcement of lint and style rules:

Step 1: Auto-fix all remaining lint and style check failures:

npm run lint:fix

Step 2: Enable pre-commit hook and CI enforcement:

npm i -D lint-staged
     "lint": "eslint && prettier -c .",
-    "lint:ci": "true # TODO: eslint -f gha && prettier -c .",
+    "lint:ci": "eslint -f gha && prettier -c .",
     "lint:fix": "eslint --fix && prettier -w .",

@hoborm
hoborm self-requested a review May 27, 2026 20:35
@hoborm hoborm self-assigned this May 27, 2026
@scottanderson
scottanderson marked this pull request as draft May 28, 2026 21:34
@scottanderson
scottanderson force-pushed the eslint branch 6 times, most recently from e3a5ace to 5ee9597 Compare May 29, 2026 00:21
@scottanderson
scottanderson marked this pull request as ready for review May 29, 2026 00:22
@scottanderson
scottanderson force-pushed the eslint branch 4 times, most recently from 3dcbf37 to d65568b Compare June 1, 2026 20:11
@scottanderson
scottanderson changed the base branch from main to develop June 26, 2026 22:28
@scottanderson
scottanderson force-pushed the eslint branch 4 times, most recently from beb34e9 to 9673416 Compare July 29, 2026 02:12

<p>
<em>Applies to both Cloud and Self-Hosted Services</em>
</p>

@scottanderson scottanderson Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auto-formatter incorrectly removes the closing </p> tag due to a bug, causing a secondary build failure because the unclosed tag is invalid JSX. The correct formatting is included here so that the code can be formatted by running npm run lint:fix without creating this build failure.

Remove branch restriction for push events, which prevents forked projects from running CI checks prior to creating a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants