Member info#28
Draft
domshyra wants to merge 12 commits into
Draft
Conversation
fixed some colums map and
domshyra
commented
Jun 22, 2021
| /// </summary> | ||
| public interface IExporter | ||
| { | ||
| //TODO: fix for LazyColumn |
domshyra
commented
Jul 7, 2021
| /// <summary> | ||
| /// Pre defined export location based on colom order, finds colums based on names provided | ||
| /// </summary> | ||
| public class InAndOutColumn : UninformedImportColumn |
Owner
Author
There was a problem hiding this comment.
I still hate this name.... MirrorColumn? ImportAndExportColumn? This part still needs some work...
Owner
Author
There was a problem hiding this comment.
How do I say this works with both uninformed and infomed
domshyra
commented
Jul 8, 2021
domshyra
left a comment
domshyra
left a comment
Owner
Author
There was a problem hiding this comment.
Tests still need to be done too
| /// <summary> | ||
| /// Pre defined export location based on colom order, finds colums based on names provided | ||
| /// </summary> | ||
| public class InAndOutColumn : UninformedImportColumn |
Owner
Author
There was a problem hiding this comment.
How do I say this works with both uninformed and infomed
| /// </summary> | ||
| public int? DecimalPrecision { get; set; } | ||
|
|
||
| public int? ColumnNumber { get; set; } |
|
|
||
| namespace ExcelExtensions.Interfaces.Import | ||
| { | ||
| //todo fix these comments |
| /// </summary> | ||
| public bool IsRequired { get; set; } | ||
|
|
||
| //Might be able to deprecate this ????????? who knows yet |
Owner
Author
There was a problem hiding this comment.
Add more descript comment as to why I can deprecate it
| /// <summary> | ||
| /// Represents the human readable column header name/title | ||
| /// </summary> | ||
| public string DisplayName { get; set; } |
| { | ||
| public bool IsRequired { get; set; } | ||
| /// <summary> | ||
| /// Represent severity if this column is not found while parsing |
| { | ||
|
|
||
| /// <summary> | ||
| /// SCAN AND PARSE |
| /// <para>If not options we will add the display name</para> | ||
| /// </summary> | ||
| /// <param name="modelPropertyName"></param> | ||
| /// <param name="displayName"></param> |
Owner
Author
|
Web layer also needs to be updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.