animator: Force data ordering and mark as matching. - #52
Merged
Conversation
The theory is that data ordering was altered by _unused_ functions that were part of the compilation in the original game but were ultimately stripped of the binary. The symbols do not appear in the program, but the data remains. The solution is to define a counter unused function that defines the data in the order in which it appears in the original data section.
Collaborator
|
This was my observation too, according to the symbol map there are a few unused functions which probably used these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theory is that data ordering was altered by unused functions that were part of the compilation in the original game but were ultimately stripped of the binary. The symbols do not appear in the program, but the data remains.
The solution is to define a counter unused function that defines the data in the order in which it appears in the original data section.