fix(vlm): load code formula processor from repo id - #4128
Conversation
|
❌ DCO Check Failed Hi @lorenzozanee, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for lorenzozanee <wyz0707@proton.me>
I, lorenzozanee <wyz0707@proton.me>, hereby add my Signed-off-by to this commit: ac06b5098be2c730cfa14941500d4648612907d7"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: lorenzozanee <wyz0707@proton.me>
|
@lorenzozanee Your suggested fix breaks the contract that an artifact_path is always provided when docling must run offline. It also does not address #2568 at all. The behaviour seen there is not an artifact of wrong preprocessing, it is native extraction / image-export behavior when the code-formula model does not run. Hence I will close this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes #2568
Formula enrichment was loading the processor from the cache path, which can misresolve tokenizer and config data for the CodeFormulaV2 VLM path.
Keep the processor on the repo id while leaving weights and generation config on the resolved cache path.
Tests:
uv run pytest tests/test_transformers_engine_processor_source.py -q